Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 462103004: GN: Bug fixes in process_file_template (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

GN: Bug fixes in process_file_template process_file_template would fail when the template argument was a string instead of a list, but the previous behavior (and the documentation) describes it as being able to take a string or a list as an argument. It would also fail if the result was not an absolute file. This is required for most uses of sources expansions, but not for process_file_template which just returns the strings of whatever the results were. This adds "AsStrings" version of the sources expansions writer. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289112

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : ihoist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -19 lines) Patch
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/function_process_file_template.cc View 1 2 2 chunks +22 lines, -13 lines 0 comments Download
A tools/gn/function_process_file_template_unittest.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/substitution_writer.h View 3 chunks +18 lines, -1 line 0 comments Download
M tools/gn/substitution_writer.cc View 4 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 4 months ago (2014-08-12 20:11:48 UTC) #1
jamesr
lgtm https://codereview.chromium.org/462103004/diff/20001/tools/gn/function_process_file_template.cc File tools/gn/function_process_file_template.cc (right): https://codereview.chromium.org/462103004/diff/20001/tools/gn/function_process_file_template.cc#newcode79 tools/gn/function_process_file_template.cc:79: if (args[1].type() == Value::STRING) { could you hoist ...
6 years, 4 months ago (2014-08-12 20:20:33 UTC) #2
brettw
6 years, 4 months ago (2014-08-12 23:29:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 289112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698