Chromium Code Reviews Chromium Code Reviews
Issue 462103002:
Extract "fullscreen element ready check" from requestFullscreen() (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html |
| diff --git a/LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html b/LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..25d4b063745367ef11318d44832bbb8c24f06c04 |
| --- /dev/null |
| +++ b/LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html |
| @@ -0,0 +1,27 @@ |
| +<!DOCTYPE html> |
| +<title>Element ready check for child of a fullscreen iframe</title> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script src="../trusted-event.js"></script> |
| +<div id="log"></div> |
| +<iframe><!-- script inserts child here --></iframe> |
| +<script> |
| +// Verify that an iframe can itself go fullscreen, and that this doesn't |
| +// influence the iframe ancestor test of the element ready check. |
| +async_test(function(t) |
| +{ |
| + var iframe = document.querySelector("iframe"); |
| + document.onfullscreenchange = t.step_func(function() |
| + { |
| + assert_equals(document.fullscreenElement, iframe, "fullscreen element"); |
| + var div = document.createElement("div"); |
| + iframe.appendChild(div); |
|
falken
2014/08/13 04:26:57
I might not understand iframes well enough. Why do
philipj_slow
2014/08/13 07:38:36
This is the core of our misunderstanding :) The sp
falken
2014/08/13 07:49:40
Ah, I somewhat suspected that. So wrt the spec tex
philipj_slow
2014/08/13 08:12:14
Right, if you click through to the definition of "
falken
2014/08/13 08:45:15
OK, I get it now. I actually had clicked through b
|
| + assert_equals(div.parentNode, iframe, "FIXME bla bla"); |
| + assert_equals(div.ownerDocument, document, "FIXME bla blass"); |
|
falken
2014/08/13 04:26:57
FIXMEs :)
philipj_slow
2014/08/13 07:38:36
Will remove, they're paranoid checks I added while
|
| + trusted_request(div, iframe.contentDocument.body); |
| + document.onfullscreenchange = t.unreached_func("second fullscreenchange event"); |
| + document.onfullscreenerror = t.step_func_done(); |
| + }); |
| + trusted_request(iframe); |
| +}); |
| +</script> |
