LayoutTests/fullscreen/api/element-ready-check-fullscreen-element-sibling.html - Issue 462103002: Extract "fullscreen element ready check" from requestFullscreen()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/api/element-ready-check-fullscreen-element-sibling.html

Issue 462103002: Extract "fullscreen element ready check" from requestFullscreen() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fullscreen/api/element-ready-check-enabled-flag-not-set.html ('k') | LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html » ('j') | LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Element ready check for sibling of fullscreen element</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../trusted-event.js"></script>

	6 <div id="log"></div>

	7 <div id="a"></div>

	8 <div id="b"></div>

	9 <script>

	10 async_test(function(t)

	11 {

	12 var a = document.getElementById("a");

	13 var b = document.getElementById("b");

	14 document.onfullscreenchange = t.step_func(function()

	15 {

	16 assert_equals(document.fullscreenElement, a, "fullscreen element");

	17 trusted_request(b);
	falken 2014/08/13 04:26:57 Should the onfullscreen* be set before the request Should the onfullscreen* be set before the request? philipj_slow 2014/08/13 07:38:36 It can be, but when the event is async I'm in the Show quoted text On 2014/08/13 04:26:57, falken wrote: > Should the onfullscreen* be set before the request? It can be, but when the event is async I'm in the habit of adding the event listener as late as possible, to fail in case the event is actually sync. Presto had bugs like this and I've found them in Gecko too: https://bugzilla.mozilla.org/show_bug.cgi?id=975270 falken 2014/08/13 07:49:40 Ah, interesting! Thanks. Show quoted text On 2014/08/13 07:38:36, philipj wrote: > On 2014/08/13 04:26:57, falken wrote: > > Should the onfullscreen* be set before the request? > > It can be, but when the event is async I'm in the habit of adding the event > listener as late as possible, to fail in case the event is actually sync. Presto > had bugs like this and I've found them in Gecko too: > https://bugzilla.mozilla.org/show_bug.cgi?id=975270 Ah, interesting! Thanks.
	18 document.onfullscreenchange = t.unreached_func("second fullscreenchange event");

	19 document.onfullscreenerror = t.step_func_done();

	20 });

	21 trusted_request(a);

	22 });

	23 </script>

OLD	NEW