Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 462083003: Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/) Reason for revert: Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab Original issue's description: > site isolation: cross-site transfers should track the RenderFrameHost, not the View > > This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap. > > 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames. > > 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating. > > 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state. > > BUG=304341, 400850 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867 TBR=creis@chromium.org,nick@chromium.org NOTREECHECKS=true NOTRY=true BUG=304341, 400850 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -180 lines) Patch
M content/browser/cross_site_request_manager.h View 3 chunks +13 lines, -13 lines 0 comments Download
M content/browser/cross_site_request_manager.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -48 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 6 chunks +4 lines, -47 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 7 chunks +21 lines, -14 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +48 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 5 chunks +45 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 4 chunks +22 lines, -21 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Created Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View
6 years, 4 months ago (2014-08-12 19:22:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/462083003/1
6 years, 4 months ago (2014-08-12 19:25:59 UTC) #2
commit-bot: I haz the power
Change committed as 289049
6 years, 4 months ago (2014-08-12 19:29:52 UTC) #3
pkotwicz
6 years, 4 months ago (2014-08-12 22:01:47 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/466933003/ by pkotwicz@chromium.org.

The reason for reverting is: The CL turns out to be innocent. Reverting the
revert.

Powered by Google App Engine
This is Rietveld 408576698