DevTools: do not scroll console to bottom on resize

DevTools: do not scroll console to bottom on resize

Currently console gets scrolled to bottom whenever it gets resized.
The patch fixes this erroneous behavior.

R=vsevik, pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180175

[lushnikov, 2014-08-12 15:13:51]

Please, take a look

[lushnikov, 2014-08-12 15:37:42]

Addressed comments

[vsevik, 2014-08-13 07:21:11]

lgtm

Could you please check the case where we switch away from the console panel,
then resize inspector and then go back to console? I think it should be fine,
just to be on the safe side.

https://chromiumcodereview.appspot.com/462083002/diff/20001/Source/devtools/f...
File Source/devtools/front_end/console/ConsoleView.js (right):

https://chromiumcodereview.appspot.com/462083002/diff/20001/Source/devtools/f...
Source/devtools/front_end/console/ConsoleView.js:436: if
(this._viewport.scrolledToBottom())
Is similar code still needed in restoreScrollPositions() method as well as the
this._scrolledToBottom field?

[lushnikov, 2014-08-13 12:33:33]

@vsevik, I removed ConsoleView._scrolledToBottom variable - indeed, it's not
needed any more.

I tested different scenarios, and console view seems to be working as intended.
Would you mind taking another look on these changes?

[vsevik, 2014-08-13 12:38:27]

lgtm

https://codereview.chromium.org/462083002/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/console/ConsoleView.js (right):

https://codereview.chromium.org/462083002/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/console/ConsoleView.js:430:
this._immediatelyScrollIntoView();
Would you mind renaming this to this._immediatelyScrollPromptIntoView() while
you are here?
Current naming is confusing :(

[lushnikov, 2014-08-13 12:45:44]

On 2014/08/13 12:38:27, vsevik wrote:
> lgtm
> 
>
https://codereview.chromium.org/462083002/diff/40001/Source/devtools/front_en...
> File Source/devtools/front_end/console/ConsoleView.js (right):
> 
>
https://codereview.chromium.org/462083002/diff/40001/Source/devtools/front_en...
> Source/devtools/front_end/console/ConsoleView.js:430:
> this._immediatelyScrollIntoView();
> Would you mind renaming this to this._immediatelyScrollPromptIntoView() while
> you are here?
> Current naming is confusing :(

Sure! Thank you!

[lushnikov, 2014-08-13 12:45:47]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-08-13 12:45:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/462083002/60001

[commit-bot: I haz the power, 2014-08-13 13:50:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22534)

[commit-bot: I haz the power, 2014-08-13 13:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 13:54:34]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[lushnikov, 2014-08-13 14:03:27]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-08-13 14:04:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/462083002/60001

[commit-bot: I haz the power, 2014-08-13 14:25:30]

Committed patchset #4 (60001) as 180175