Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 462053002: [XHR] Call internalAbort() before firing events (Closed)

Created:
6 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 4 months ago
Reviewers:
sof
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

[XHR] Call internalAbort() before firing events If we fire internalAbort() after handleRequestError(), a new request initiated by the event handler reusing the same XHR instance will be aborted. BUG=402855 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 4 months ago (2014-08-12 13:43:35 UTC) #1
sof
lgtm
6 years, 4 months ago (2014-08-13 12:46:31 UTC) #2
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-14 03:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/462053002/1
6 years, 4 months ago (2014-08-14 03:11:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 10:37:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 13:08:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/21343)
6 years, 4 months ago (2014-08-14 13:08:56 UTC) #7
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-15 03:42:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/462053002/1
6 years, 4 months ago (2014-08-15 03:43:02 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 04:39:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 180326

Powered by Google App Engine
This is Rietveld 408576698