Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 462043003: [Resources] Update the resources for the themed new avatar button. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Resources] Update the resources for the themed new avatar button. The old resources had too much bottom padding, and the radius of the bottom corners was incorrect There is a small related code change that fixes the size of the button here: https://codereview.chromium.org/460233003/ Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMd214MHJSbzlUcFk&authuser=1 BUG=395798 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289352

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : moved code to separate CL #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_arrow.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_bottom.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_bottom_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_bottom_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_center.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_bottom.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_bottom_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_bottom_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_center.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_top.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_top_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_hover_top_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_bottom.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_bottom_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_bottom_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_center.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_top.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_top_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_pressed_top_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_top.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_top_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/win/avatar_button/themed/sign_in_button_top_right.png View Binary file 0 comments Download

Messages

Total messages: 8 (0 generated)
noms (inactive)
Hi, We've updated the resources for the themed new avatar button. This made the button ...
6 years, 4 months ago (2014-08-12 14:34:29 UTC) #1
msw
Can we cut the assets' top pixel if they're always one or two pixels too ...
6 years, 4 months ago (2014-08-12 15:18:52 UTC) #2
noms (inactive)
We are not doing exactly the same thing as the min/max buttons -- those are ...
6 years, 4 months ago (2014-08-12 19:16:00 UTC) #3
noms (inactive)
I've moved the code part of this CL to https://codereview.chromium.org/462043003/ and made Mike a reviewer ...
6 years, 4 months ago (2014-08-12 21:10:46 UTC) #4
noms (inactive)
oshima: ping!
6 years, 4 months ago (2014-08-13 13:30:06 UTC) #5
oshima
lgtm please double check with UX/PM if missing 2x assets are by design.
6 years, 4 months ago (2014-08-13 19:35:11 UTC) #6
noms (inactive)
Will do. Started an email thread. Thanks! On 2014/08/13 19:35:11, oshima wrote: > lgtm > ...
6 years, 4 months ago (2014-08-13 19:52:51 UTC) #7
noms (inactive)
6 years, 4 months ago (2014-08-13 19:57:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as 289352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698