Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome_frame/test/chrome_frame_unittests.cc

Issue 462041: Re-enable CFInstall tests after buildbot restart. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_unittests.cc
===================================================================
--- chrome_frame/test/chrome_frame_unittests.cc (revision 33845)
+++ chrome_frame/test/chrome_frame_unittests.cc (working copy)
@@ -574,32 +574,25 @@
const wchar_t kCFInstallBasicTestPage[] = L"files/CFInstall_basic.html";
-// Disabling the following tests as the consistently fail on the chrome frame
-// builder.
-// 1. FullTabIE_CFInstallBasic
-// 2. FullTabIE_CFInstallDismiss
-// 3. FullTabIE_CFInstallOverlay
-// 4. FullTabIE_CFInstallPlace
-// Issue:- http://code.google.com/p/chromium/issues/detail?id=29193
-TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabIE_CFInstallBasic) {
+TEST_F(ChromeFrameTestWithWebServer, FullTabIE_CFInstallBasic) {
SimpleBrowserTest(IE, kCFInstallBasicTestPage, L"CFInstallBasic");
}
const wchar_t kCFInstallPlaceTestPage[] = L"files/CFInstall_place.html";
-TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabIE_CFInstallPlace) {
+TEST_F(ChromeFrameTestWithWebServer, FullTabIE_CFInstallPlace) {
SimpleBrowserTest(IE, kCFInstallPlaceTestPage, L"CFInstallPlace");
}
const wchar_t kCFInstallOverlayTestPage[] = L"files/CFInstall_overlay.html";
-TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabIE_CFInstallOverlay) {
+TEST_F(ChromeFrameTestWithWebServer, FullTabIE_CFInstallOverlay) {
SimpleBrowserTest(IE, kCFInstallOverlayTestPage, L"CFInstallOverlay");
}
const wchar_t kCFInstallDismissTestPage[] = L"files/CFInstall_dismiss.html";
-TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabIE_CFInstallDismiss) {
+TEST_F(ChromeFrameTestWithWebServer, FullTabIE_CFInstallDismiss) {
SimpleBrowserTest(IE, kCFInstallDismissTestPage, L"CFInstallDismiss");
}
@@ -1452,7 +1445,7 @@
// This test checks if window.open calls issued by a full tab mode ChromeFrame
// instance make it back to IE and then transitions back to Chrome as the
// window.open target page is supposed to render within Chrome.
-TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowOpen) {
+TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabModeIE_WindowOpen) {
TimedMsgLoop loop;
CComObjectStackEx<MockWebBrowserEventSink> mock;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698