Issue 462011: Notify user that Chrome is already synced if promo banner "sync me" link is c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 462011: Notify user that Chrome is already synced if promo banner "sync me" link is c... (Closed)

Created:
11 years ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Notify user that Chrome is already synced if promo banner "sync me" link is clicked. BUG=28795 TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced.

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	chrome/browser/dom_ui/new_tab_page_sync_handler.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Please make sure the try servers pass.

Expand Messages | Collapse Messages