Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 461963002: Revert of Oilpan: fix build after r180052. (Closed)

Created:
6 years, 4 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 4 months ago
Reviewers:
haraken, oilpan-reviews, sof
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: fix build after r180052. (https://codereview.chromium.org/460983002/) Reason for revert: Android Builder failed to compile Original issue's description: > Oilpan: fix build after r180052. > > TBR=haraken,oilpan-reviews > BUG=383813 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180061 TBR=haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/dom/FullscreenElementStack.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fabrice (no longer in Chrome)
Created Revert of Oilpan: fix build after r180052.
6 years, 4 months ago (2014-08-12 11:12:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/461963002/1
6 years, 4 months ago (2014-08-12 11:13:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 11:13:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-12 11:13:19 UTC) #4
haraken
LGTM (though I'm not sure why it broke Android bots).
6 years, 4 months ago (2014-08-12 11:14:34 UTC) #5
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-12 11:14:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/461963002/1
6 years, 4 months ago (2014-08-12 11:15:19 UTC) #7
commit-bot: I haz the power
Change committed as 180062
6 years, 4 months ago (2014-08-12 11:15:52 UTC) #8
sof
6 years, 4 months ago (2014-08-12 11:27:14 UTC) #9
Message was sent while issue was closed.
On 2014/08/12 11:14:34, haraken wrote:
> LGTM (though I'm not sure why it broke Android bots).

It gets confused by not being within the namespace scope -
https://codereview.chromium.org/463633004/ does that instead.

Powered by Google App Engine
This is Rietveld 408576698