Issue 461933003: Fix missing or broken include guard macros in pdfium headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461933003: Fix missing or broken include guard macros in pdfium headers. (Closed)

Created:
6 years, 4 months ago by Tom Sepez

Modified:
6 years, 4 months ago

Reviewers:
jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Fix missing or broken include guard macros in pdfium headers. This has no ill-effect at present, but may be distracting when viewing the file since it just looks wrong. R=jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/9fa56b7

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
M	core/include/fpdfdoc/fpdf_ap.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	core/src/fpdfdoc/pdf_vt.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	core/src/fxge/dib/dib_int.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	core/src/fxge/ge/text_int.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	fpdfsdk/include/formfiller/FFL_Utils.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jun_fang

On 2014/08/12 20:30:24, Tom Sepez wrote: > Jun, a quick review. Thanks. LGTM

6 years, 4 months ago (2014-08-12 21:13:30 UTC) #2

Tom Sepez

6 years, 4 months ago (2014-08-12 21:43:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 9fa56b7 (presubmit successful).