Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: test/cctest/compiler/test-simplified-lowering.cc

Issue 461933002: Enable more tests for simplified lowering after assuming signed for word32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc
index 1fcef85a91c92753c7aef292de8b039556e942e8..0416121a1f50587ff820c13f1d2e1a60071584a6 100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -1006,13 +1006,10 @@ void CheckChangeInsertion(IrOpcode::Value expected, RepType from, RepType to) {
TEST(InsertBasicChanges) {
- if (false) {
- // TODO(titzer): these changes need the output to have the right type.
- CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, rFloat64, tInt32);
- CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, rFloat64, tUint32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, rTagged, tInt32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, rTagged, tUint32);
- }
+ CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, rFloat64, tInt32);
+ CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, rFloat64, tUint32);
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, rTagged, tInt32);
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, rTagged, tUint32);
CheckChangeInsertion(IrOpcode::kChangeFloat64ToTagged, rFloat64, rTagged);
CheckChangeInsertion(IrOpcode::kChangeTaggedToFloat64, rTagged, rFloat64);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698