Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461903002: GN: Add mojo_shell_tests, get more things working on android (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Add mojo_shell_tests, get more things working on android R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289133

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix up android linking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -55 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +9 lines, -9 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/environment/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M mojo/mojo.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_public.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +49 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 1 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 2 3 chunks +41 lines, -2 lines 0 comments Download
A mojo/system.gni View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/libxslt/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/BUILD.gn View 1 chunk +13 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jamesr
Depends on https://codereview.chromium.org/462983002/
6 years, 4 months ago (2014-08-12 05:56:42 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-12 18:15:46 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 18:17:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/461903002/1
6 years, 4 months ago (2014-08-12 18:19:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-12 18:33:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 18:37:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/51401) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40670) android_aosp ...
6 years, 4 months ago (2014-08-12 18:37:47 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 19:26:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/461903002/20001
6 years, 4 months ago (2014-08-12 19:30:12 UTC) #9
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 19:47:25 UTC) #10
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 19:54:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/461903002/40001
6 years, 4 months ago (2014-08-12 19:58:00 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 22:57:15 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 00:09:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/6109)
6 years, 4 months ago (2014-08-13 00:09:52 UTC) #15
jamesr
6 years, 4 months ago (2014-08-13 00:22:23 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 manually as 289133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698