Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 46183008: Unnecessary includes are also a layering violation. (Closed)

Created:
7 years, 1 month ago by atreat
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Unnecessary includes are also a layering violation. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161189

Patch Set 1 #

Patch Set 2 : Add ScrollbarThemeClient.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/platform/ScrollbarThemeMacCommon.mm View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
atreat
I'll need to test this on the mac trybot, but I don't think these includes ...
7 years, 1 month ago (2013-10-30 14:22:26 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-30 16:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/46183008/1
7 years, 1 month ago (2013-10-30 16:03:36 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-30 16:29:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/46183008/1
7 years, 1 month ago (2013-10-30 20:12:06 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-30 20:24:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/46183008/190001
7 years, 1 month ago (2013-11-01 15:35:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=1673
7 years, 1 month ago (2013-11-01 17:09:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/46183008/190001
7 years, 1 month ago (2013-11-01 17:30:01 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 19:05:14 UTC) #10
Message was sent while issue was closed. 
Change committed as 161189

Powered by Google App Engine
This is Rietveld 408576698