Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 461773002: Do not build device/bluetooth strings when extensions are disabled. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
miket_OOO, rpaquay
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Do not build device/bluetooth strings when extensions are disabled. BUG=334407 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288953

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M chrome/chrome_repack_locales.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 6 chunks +17 lines, -10 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-11 22:41:36 UTC) #1
rpaquay
On 2014/08/11 22:41:36, Lei Zhang wrote: I have very little context to review this change ...
6 years, 4 months ago (2014-08-11 23:25:21 UTC) #2
Lei Zhang
+miket, who reviewed both r183953 and r203652
6 years, 4 months ago (2014-08-11 23:32:48 UTC) #3
miket_OOO
lgtm https://codereview.chromium.org/461773002/diff/1/chrome/tools/build/repack_locales.py File chrome/tools/build/repack_locales.py (right): https://codereview.chromium.org/461773002/diff/1/chrome/tools/build/repack_locales.py#newcode105 chrome/tools/build/repack_locales.py:105: #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/strings/app_locale_settings_da.pak', I'm not sure why this moved, ...
6 years, 4 months ago (2014-08-11 23:35:32 UTC) #4
Lei Zhang
https://codereview.chromium.org/461773002/diff/1/chrome/tools/build/repack_locales.py File chrome/tools/build/repack_locales.py (right): https://codereview.chromium.org/461773002/diff/1/chrome/tools/build/repack_locales.py#newcode105 chrome/tools/build/repack_locales.py:105: #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/strings/app_locale_settings_da.pak', On 2014/08/11 23:35:32, miket wrote: > I'm ...
6 years, 4 months ago (2014-08-11 23:37:55 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-11 23:37:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/461773002/1
6 years, 4 months ago (2014-08-11 23:40:02 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 14:29:20 UTC) #8
Message was sent while issue was closed.
Change committed as 288953

Powered by Google App Engine
This is Rietveld 408576698