Issue 461693004: Let skia build with clang's integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461693004: Let skia build with clang's integrated assembler. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Let skia build with clang's integrated assembler. 1. vuzpq is a gcc instruction. Replace it with the equivalent vuzp (see http://llvm.org/PR20423) 2. .func / .endfunc only have an effect with -gstabs, which we don't use. As it's unused and clang doesn't support it, remove .func / .endfunc (also see http://llvm.org/20424) BUG=chromium:124610 Committed: https://skia.googlesource.com/skia/+/ea13afff6e46d8a969611cdd56c996bfb05a27c1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
M	src/opts/SkBlitRow_opts_arm_neon.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/opts/memset16_neon.S	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/opts/memset32_neon.S	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/thakis@chromium.org/461693004/10004

6 years, 4 months ago (2014-08-11 22:17:43 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 22:27:31 UTC) #4

Message was sent while issue was closed.

Change committed as ea13afff6e46d8a969611cdd56c996bfb05a27c1