Issue 461653002: Assume signed for converting to word32/float64 unless use or output is explicitly unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461653002: Assume signed for converting to word32/float64 unless use or output is explicitly unsigned. (Closed)

Created:
6 years, 4 months ago by titzer

Modified:
6 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Assume signed for converting to word32/float64 unless use or output is explicitly unsigned. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23067

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -33 lines)			Patch
	M	src/compiler/representation-change.h	View		4 chunks	+16 lines, -21 lines	1 comment	Download
	M	test/cctest/compiler/test-representation-change.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/461653002/diff/1/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/461653002/diff/1/src/compiler/representation-change.h#newcode187 src/compiler/representation-change.h:187: double value = ValueOf<double>(node->op()); Can we call DCHECK(Is[Uint|Int]32Double(value)) ...

6 years, 4 months ago (2014-08-11 16:10:19 UTC) #2

titzer

On 2014/08/11 16:10:19, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/461653002/diff/1/src/compiler/representation-change.h > File src/compiler/representation-change.h (right): ...

6 years, 4 months ago (2014-08-11 16:13:35 UTC) #3

titzer

6 years, 4 months ago (2014-08-12 08:09:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 23067 (presubmit successful).

Expand Messages | Collapse Messages