components/translate/content/renderer/data_file_renderer_cld_data_provider.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make some of the harness factory methods private Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/content/renderer/data_file_renderer_cld_data_provider.h ('k') | components/translate/content/renderer/renderer_cld_data_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

diff --git a/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc b/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

index b7a6ad27a2ec83391230007106725695ebd34bac..f2af81b3bb40781ac491dde6882fc13c771c0937 100644

--- a/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

+++ b/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

@@ -31,16 +31,6 @@ base::LazyInstance<CLDMmapWrapper>::Leaky g_cld_mmap =

namespace translate {

-// Implementation of the static factory method from RendererCldDataProvider,

-// hooking up this specific implementation for all of Chromium.

-RendererCldDataProvider* CreateRendererCldDataProviderFor(

- content::RenderViewObserver* render_view_observer) {

- // This log line is to help with determining which kind of provider has been

- // configured. See also: chrome://translate-internals

- VLOG(1) << "Creating DataFileRendererCldDataProvider";

- return new DataFileRendererCldDataProvider(render_view_observer);

DataFileRendererCldDataProvider::DataFileRendererCldDataProvider(

content::RenderViewObserver* render_view_observer)

: render_view_observer_(render_view_observer) {