components/translate/content/browser/data_file_browser_cld_data_provider.h - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/data_file_browser_cld_data_provider.h

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make some of the harness factory methods private Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/content/browser/browser_cld_utils.cc ('k') | components/translate/content/browser/data_file_browser_cld_data_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/data_file_browser_cld_data_provider.h

diff --git a/components/translate/content/browser/data_file_browser_cld_data_provider.h b/components/translate/content/browser/data_file_browser_cld_data_provider.h

index 7b4f17e96746e6bca5fdfa1986baa1ecdd41be89..687d2b591a66da7cfebae07dd072d8617b46e151 100644

--- a/components/translate/content/browser/data_file_browser_cld_data_provider.h

+++ b/components/translate/content/browser/data_file_browser_cld_data_provider.h

@@ -12,16 +12,21 @@

#include "base/memory/weak_ptr.h"

#include "components/translate/content/browser/browser_cld_data_provider.h"

+namespace content {

+class WebContents;

namespace translate {

class DataFileBrowserCldDataProvider : public BrowserCldDataProvider {

public:

explicit DataFileBrowserCldDataProvider(content::WebContents*);

- virtual ~DataFileBrowserCldDataProvider();

+ ~DataFileBrowserCldDataProvider() override;

// BrowserCldDataProvider implementations:

- virtual bool OnMessageReceived(const IPC::Message&) override;

- virtual void OnCldDataRequest() override;

- virtual void SendCldDataResponse() override;

+ bool OnMessageReceived(const IPC::Message&) override;

+ void OnCldDataRequest() override;

+ void SendCldDataResponse() override;

private:

void SendCldDataResponseInternal(const base::File*,