components/translate/content/browser/browser_cld_data_provider.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/browser_cld_data_provider.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make some of the harness factory methods private Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/content/browser/browser_cld_data_provider.h ('k') | components/translate/content/browser/browser_cld_data_provider_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/browser_cld_data_provider.cc

diff --git a/components/translate/core/common/translate_constants.cc b/components/translate/content/browser/browser_cld_data_provider.cc

similarity index 52%

copy from components/translate/core/common/translate_constants.cc

copy to components/translate/content/browser/browser_cld_data_provider.cc

index 7b2034e5ad164ac450f67f379497929733191ab5..a73e494c41101f430f69b5b6483de633dead882f 100644

--- a/components/translate/core/common/translate_constants.cc

+++ b/components/translate/content/browser/browser_cld_data_provider.cc

@@ -2,10 +2,12 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "components/translate/core/common/translate_constants.h"

+#include "components/translate/content/browser/browser_cld_data_provider.h"

namespace translate {

-const char* const kUnknownLanguageCode = "und";

+bool BrowserCldDataProvider::OnMessageReceived(const IPC::Message& message) {

+ return false; // Message not handled

} // namespace translate