Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make some of the harness factory methods private Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/static_cld_data_harness.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager_browsertest.cc
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index ccf32c511336693c0503b33f6160bc9ec5fdb3ed..7dab3efe9ecf711e9430195186d1e6b442dd3d9f 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/translate/cld_data_harness.h"
+#include "chrome/browser/translate/cld_data_harness_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -29,7 +30,7 @@ class TranslateManagerBrowserTest : public InProcessBrowserTest {};
IN_PROC_BROWSER_TEST_F(TranslateManagerBrowserTest,
MAYBE_PRE_TranslateSessionRestore) {
scoped_ptr<test::CldDataHarness> cld_data_harness =
- test::CreateCldDataHarness();
+ test::CldDataHarnessFactory::Get()->CreateCldDataHarness();
ASSERT_NO_FATAL_FAILURE(cld_data_harness->Init());
SessionStartupPref pref(SessionStartupPref::LAST);
SessionStartupPref::SetStartupPref(browser()->profile(), pref);
@@ -65,7 +66,7 @@ IN_PROC_BROWSER_TEST_F(TranslateManagerBrowserTest,
IN_PROC_BROWSER_TEST_F(TranslateManagerBrowserTest,
MAYBE_TranslateSessionRestore) {
scoped_ptr<test::CldDataHarness> cld_data_harness =
- test::CreateCldDataHarness();
+ test::CldDataHarnessFactory::Get()->CreateCldDataHarness();
ASSERT_NO_FATAL_FAILURE(cld_data_harness->Init());
content::WebContents* current_web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
« no previous file with comments | « chrome/browser/translate/static_cld_data_harness.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698