chrome/browser/translate/component_cld_data_harness.h - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/component_cld_data_harness.h

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make some of the harness factory methods private Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/cld_data_harness_factory.cc ('k') | chrome/browser/translate/component_cld_data_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/component_cld_data_harness.h

diff --git a/chrome/browser/translate/component_cld_data_harness.h b/chrome/browser/translate/component_cld_data_harness.h

index dbf249413bb64efb97faca123875a70ea24996e8..d3da55dc6d961c6747e01efa0fd4893838cce20c 100644

--- a/chrome/browser/translate/component_cld_data_harness.h

+++ b/chrome/browser/translate/component_cld_data_harness.h

@@ -10,11 +10,14 @@

namespace test {

+// Utility class that sets up a test harness suitable for injecting a

+// component-updater-based CLD data file into the runtime. See CldDataHarness

+// class for more details.

class ComponentCldDataHarness : public CldDataHarness {

public:

- ComponentCldDataHarness();

- virtual ~ComponentCldDataHarness();

- virtual void Init() override;

+ ComponentCldDataHarness() {}

+ ~ComponentCldDataHarness() override;

+ void Init() override;

private:

void ClearComponentDataFileState();

« no previous file with comments | « chrome/browser/translate/cld_data_harness_factory.cc ('k') | chrome/browser/translate/component_cld_data_harness.cc » ('j') | no next file with comments »