chrome/chrome.gyp - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: All remaining comments addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi ('K') | « chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc ('k') | chrome/chrome_renderer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index b7d4fce58e4bb475ad7ad16765df78681fbb0fc5..2e90e7558831103c7c60ee485fa6db6216c2b012 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -39,6 +39,14 @@

'../content/content.gyp:content_ppapi_plugin',

'../third_party/WebKit/public/blink_devtools.gyp:blink_devtools_frontend_resources',

+ 'conditions': [

+ [ 'cld_version==2', {

+ 'chromium_child_dependencies': [

+ # Use whatever CLD2 data access mode that the application

+ # embedder is using.

+ '../third_party/cld_2/cld_2.gyp:cld2_platform_impl', ],

+ }],

picksi1 2014/10/30 17:37:32 as above, does this also need to have a check for

Andrew Hayden (chromium.org) 2014/10/30 17:51:13 It should, yes.

Andrew Hayden (chromium.org) 2014/10/31 11:38:06 Done.

+ ],

}],

['enable_printing!=0', {

'chromium_browser_dependencies': [