components/translate/content/renderer/BUILD.gn - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/BUILD.gn

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/content/common/cld_data_source.cc ('K') | « components/translate/content/common/static_cld_data_source.cc ('k') | components/translate/content/renderer/data_file_renderer_cld_data_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/BUILD.gn

diff --git a/components/translate/content/renderer/BUILD.gn b/components/translate/content/renderer/BUILD.gn

index db461be40aeb79bda08e2d335f13c603e9d663c4..25a0e4a6a3005fce57514f7993e397a876f2e548 100644

--- a/components/translate/content/renderer/BUILD.gn

+++ b/components/translate/content/renderer/BUILD.gn

@@ -6,7 +6,11 @@ import("//build/config/features.gni")

static_library("renderer") {

sources = [

+ "data_file_renderer_cld_data_provider.cc",

+ "data_file_renderer_cld_data_provider.h",

"renderer_cld_data_provider.h",

+ "static_renderer_cld_data_provider.cc",

+ "static_renderer_cld_data_provider.h",

"translate_helper.cc",

"translate_helper.h",

]

@@ -28,15 +32,4 @@ static_library("renderer") {

deps += [ "//third_party/cld_2" ]

}

- if (cld2_data_source == "standalone" || cld2_data_source == "component") {

- sources += [

- "data_file_renderer_cld_data_provider.cc",

- "data_file_renderer_cld_data_provider.h",

- ]

- } else if (cld2_data_source == "static") {

- sources += [

- "static_renderer_cld_data_provider.cc",

- "static_renderer_cld_data_provider.h",

- ]

- }

}