components/translate/content/browser/BUILD.gn - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/BUILD.gn

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « components/translate.gypi ('k') | components/translate/content/browser/browser_cld_data_provider.h » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/BUILD.gn

diff --git a/components/translate/content/browser/BUILD.gn b/components/translate/content/browser/BUILD.gn

index d94c3387f5a4e56ca0524e88546fa254e044638e..cfcf1981f69862fbf73af9f82fb40f7cb935c223 100644

--- a/components/translate/content/browser/BUILD.gn

+++ b/components/translate/content/browser/BUILD.gn

@@ -9,6 +9,10 @@ static_library("browser") {

"browser_cld_data_provider.h",

"content_translate_driver.cc",

"content_translate_driver.h",

+ "data_file_browser_cld_data_provider.cc",

+ "data_file_browser_cld_data_provider.h",

+ "static_browser_cld_data_provider.cc",

+ "static_browser_cld_data_provider.h",

]

deps = [

@@ -17,15 +21,4 @@ static_library("browser") {

"//content/public/browser",

]

- if (cld2_data_source == "standalone" || cld2_data_source == "component") {

- sources += [

- "data_file_browser_cld_data_provider.cc",

- "data_file_browser_cld_data_provider.h",

- ]

- } else if (cld2_data_source == "static") {

- sources += [

- "static_browser_cld_data_provider.cc",

- "static_browser_cld_data_provider.h",

- ]

- }

}