chrome/chrome_tests.gypi - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests.gypi

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « chrome/chrome_renderer.gypi ('k') | components/translate.gypi » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests.gypi

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi

index 59bed22c9490513c022ef6935883227187c85166..4c039fe4a6e9eab27eb358275fbfc02b5fb18476 100644

--- a/chrome/chrome_tests.gypi

+++ b/chrome/chrome_tests.gypi

@@ -1402,9 +1402,15 @@

'browser/task_manager/task_manager_browsertest_util.cc',

'browser/task_manager/task_manager_browsertest_util.h',

'browser/themes/theme_service_browsertest.cc',

- 'browser/translate/translate_browsertest.cc',

+ 'browser/translate/component_cld_data_harness.cc',

+ 'browser/translate/component_cld_data_harness.h',

'browser/translate/cld_data_harness.cc',

'browser/translate/cld_data_harness.h',

+ 'browser/translate/cld_data_harness_factory.cc',

+ 'browser/translate/cld_data_harness_factory.h',

+ 'browser/translate/standalone_cld_data_harness.cc',

+ 'browser/translate/standalone_cld_data_harness.h',

+ 'browser/translate/translate_browsertest.cc',

'browser/translate/translate_manager_browsertest.cc',

'browser/ui/app_list/app_list_controller_browsertest.cc',

'browser/ui/app_list/app_list_service_impl_browsertest.cc',

@@ -1700,24 +1706,6 @@

'conditions': [

- ['cld2_data_source=="component"', {

- 'sources': [

- 'browser/translate/component_cld_data_harness.cc',

- 'browser/translate/component_cld_data_harness.h',

- ]},

- ],

- ['cld2_data_source=="standalone"', {

- 'sources': [

- 'browser/translate/standalone_cld_data_harness.cc',

- 'browser/translate/standalone_cld_data_harness.h',

- ]},

- ],

- ['cld2_data_source=="static"', {

- 'sources': [

- 'browser/translate/static_cld_data_harness.cc',

- 'browser/translate/static_cld_data_harness.h',

- ]},

- ],

['enable_one_click_signin==0', {

'sources!': [

'browser/ui/sync/one_click_signin_bubble_links_delegate_browsertest.cc',