Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2990)

Unified Diff: build/common.gypi

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | chrome/browser/chrome_browser_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ff91ec6f5b981641baa597a9a6de085e879fde48..2e69adf114aae51d8eab62faa3ffca0d5b95f621 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -493,21 +493,6 @@
# 2: Large tables, high accuracy
'cld2_table_size%': 2,
- # The data acquisition mode for CLD2. Possible values are:
- # static: CLD2 data is statically linked to the executable.
- # standalone: CLD2 data is provided in a standalone file that is
- # bundled with the executable.
- # component: CLD2 data is provided as a Chrome "component" and is
- # downloaded via the component updater.
- #
- # For more information on switching the CLD2 data source, see:
- # https://sites.google.com/a/chromium.org/dev/developers/how-tos/compact-language-detector-cld-data-source-configuration
- #
- # This string will be exposed in chrome://translate-internals under the
- # heading "CLD Data Source". This allows easy determination of which
- # data source the browser was built with.
- 'cld2_data_source%': 'static',
-
# Enable spell checker.
'enable_spellcheck%': 1,
@@ -1166,7 +1151,6 @@
'enable_google_now%': '<(enable_google_now)',
'cld_version%': '<(cld_version)',
'cld2_table_size%': '<(cld2_table_size)',
- 'cld2_data_source%': '<(cld2_data_source)',
'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
'disable_file_support%': '<(disable_file_support)',
'disable_ftp_support%': '<(disable_ftp_support)',
@@ -2870,11 +2854,6 @@
['cld_version!=0', {
'defines': ['CLD_VERSION=<(cld_version)'],
}],
- ['cld_version==2', {
- # This is used to populate the "CLD Data Source" field in:
- # chrome://translate-internals
- 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
- }],
['enable_printing==1', {
'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
}],
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | chrome/browser/chrome_browser_main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698