components/translate/content/browser/BUILD.gn - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/content/browser/BUILD.gn

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « components/translate.gypi ('k') | components/translate/content/browser/browser_cld_data_provider.h » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/features.gni")	5 import("//build/config/features.gni")

6	6

7 static_library("browser") {	7 static_library("browser") {

8 sources = [	8 sources = [

9 "browser_cld_data_provider.h",	9 "browser_cld_data_provider.h",

10 "content_translate_driver.cc",	10 "content_translate_driver.cc",

11 "content_translate_driver.h",	11 "content_translate_driver.h",

	12 "data_file_browser_cld_data_provider.cc",

	13 "data_file_browser_cld_data_provider.h",

	14 "static_browser_cld_data_provider.cc",

	15 "static_browser_cld_data_provider.h",

12 ]	16 ]

13	17

14 deps = [	18 deps = [

15 "//base",	19 "//base",

16 "//components/translate/core/browser",	20 "//components/translate/core/browser",

17 "//content/public/browser",	21 "//content/public/browser",

18 ]	22 ]

19	23

20 if (cld2_data_source == "standalone" \|\| cld2_data_source == "component") {

21 sources += [

22 "data_file_browser_cld_data_provider.cc",

23 "data_file_browser_cld_data_provider.h",

24 ]

25 } else if (cld2_data_source == "static") {

26 sources += [

27 "static_browser_cld_data_provider.cc",

28 "static_browser_cld_data_provider.h",

29 ]

30 }

31 }	24 }

OLD	NEW