Refactor language detection logic to allow non-static CLD data sources.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 90 matching lines @@
 #include "chrome/installer/util/google_update_settings.h"
 #include "components/component_updater/component_updater_service.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/language_usage_metrics/language_usage_metrics.h"
 #include "components/metrics/metrics_service.h"
 #include "components/metrics/profiler/tracking_synchronizer.h"
 #include "components/nacl/browser/nacl_browser.h"
 #include "components/rappor/rappor_service.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/startup_metric_utils/startup_metric_utils.h"
+#include "components/translate/content/browser/browser_cld_data_provider_factory.h"
+#include "components/translate/content/browser/static_browser_cld_data_provider.h"
+#include "components/translate/content/browser/static_browser_cld_data_provider_factory.h"
 #include "components/translate/content/common/cld_data_source.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "components/variations/variations_http_header_provider.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/common/content_client.h"
@@ skipping 279 matching lines @@
 #if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
   RegisterRecoveryComponent(cus, g_browser_process->local_state());
   RegisterPepperFlashComponent(cus);
   RegisterSwiftShaderComponent(cus);
   RegisterWidevineCdmComponent(cus);
 #if !defined(DISABLE_NACL)
   g_browser_process->pnacl_component_installer()->RegisterPnaclComponent(cus);
 #endif
 #endif
 
-  if (translate::CldDataSource::ShouldRegisterForComponentUpdates()) {
+  if (translate::CldDataSource::Get()->ShouldRegisterForComponentUpdates()) {
     RegisterCldComponent(cus);
   }
 
   base::FilePath path;
   if (PathService::Get(chrome::DIR_USER_DATA, &path)) {
 #if defined(OS_ANDROID)
     // The CRLSet component was enabled for some releases. This code attempts to
     // delete it from the local disk of those how may have downloaded it.
     g_browser_process->crl_set_fetcher()->DeleteFromDisk(path);
 #elif !defined(OS_CHROMEOS)
@@ skipping 1035 matching lines @@
   PrefMetricsService::Factory::GetForProfile(profile_);
 
   PreBrowserStart();
 
   // Instantiate the notification UI manager, as this triggers a perf timer
   // used to measure startup time. TODO(stevenjb): Figure out what is actually
   // triggering the timer and call that explicitly in the approprate place.
   // http://crbug.com/105065.
   browser_process_->notification_ui_manager();
 
+  if (!translate::BrowserCldDataProviderFactory::IsInitialized()) {
+    // Embedder hasn't specified an alternative factory, so we should set one.
+    // This must happen before calling RegisterComponentsForUpdate, because
+    // that code will register the CLD Component Updater if needed.
+    // Maintainers: Customize the default data source here as desired.
+    translate::CldDataSource::Set(translate::CldDataSource::STATIC(), false);

[picksi1, 2014/09/29 15:59:08]

What does the 'false' here mean? Can we rename the function, or turn the false
into a (e.g.) named enum so it is clear what it's doing.

[Andrew Hayden (chromium.org), 2014/10/30 14:25:14]

I'm changing to two methods: Set and SetDefault. Hopefully this will clear
things up.

+    translate::BrowserCldDataProviderFactory* factory =
+        new translate::StaticBrowserCldDataProviderFactory();
+    translate::BrowserCldDataProviderFactory::Set(factory, false);
+  }

[picksi1, 2014/09/29 15:59:08]

see comment about about 'false'.

[Andrew Hayden (chromium.org), 2014/10/30 14:25:14]

Similarly, this is now cleaned up. Now we explicitly check to see if this is the
component-updater data source.

+
   if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate))
     RegisterComponentsForUpdate();
 
 #if defined(OS_ANDROID)
   chrome_variations::VariationsService* variations_service =
       browser_process_->variations_service();
   if (variations_service) {
     variations_service->set_policy_pref_service(profile_->GetPrefs());
     variations_service->StartRepeatedVariationsSeedFetch();
   }
@@ skipping 198 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }