Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: sdk/lib/io/platform.dart

Issue 46163009: Return an absolute URI for Platform.script. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/platform_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/platform.dart
diff --git a/sdk/lib/io/platform.dart b/sdk/lib/io/platform.dart
index 16d0a1e65cacfb3f7bdcca04b1a04ca6ff7b078f..ccbbb3fb89e8b57216b39d12d67edcf637f489d3 100644
--- a/sdk/lib/io/platform.dart
+++ b/sdk/lib/io/platform.dart
@@ -80,9 +80,14 @@ class Platform {
static String get executable => _Platform.executable;
/**
- * Returns the URI of the script being run in this
- * isolate. If the URI is relative it is relative to the file URI of
- * the working directory of the VM when it was started.
+ * Returns the absolute URI of the script being run in this
+ * isolate. If the script argument on the command line is relative,
Anders Johnsen 2013/11/01 10:13:51 Newline*2 before `If`.
Bill Hesse 2013/11/01 12:49:46 Done.
+ * it is resolved to an absolute URI before fetching the script, and
+ * this absolute URI is returned.
+ *
+ * This implies that a path including "link/.." in the script name
Søren Gjesse 2013/11/01 10:17:28 Instead of trying to examplify here maybe just say
Bill Hesse 2013/11/01 12:49:46 Done. I think the specific case is worth includin
+ * is resolved by dropping the link component, which may be different
+ * from the file system's path resolution behavior.
*
* If the executable environment does not support [script] an empty
* URI is returned.
« no previous file with comments | « no previous file | sdk/lib/io/platform_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698