Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3579)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 46163003: Consolidate test contexts and remove unused ones (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index 174a27a49e425ba2f6aa889802e68995a21c5eab..deace3dedf9b6e586608e456a6f6b86abec3787a 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -246,70 +246,10 @@ class GLRendererTest : public testing::Test {
// declared above it.
} // namespace
-
-// Gives unique shader ids and unique program ids for tests that need them.
-class ShaderCreatorMockGraphicsContext : public TestWebGraphicsContext3D {
- public:
- ShaderCreatorMockGraphicsContext()
- : next_program_id_number_(10000),
- next_shader_id_number_(1) {}
-
- bool hasShader(WebGLId shader) {
- return shader_set_.find(shader) != shader_set_.end();
- }
-
- bool hasProgram(WebGLId program) {
- return program_set_.find(program) != program_set_.end();
- }
-
- virtual WebGLId createProgram() {
- unsigned program = next_program_id_number_;
- program_set_.insert(program);
- next_program_id_number_++;
- return program;
- }
-
- virtual void deleteProgram(WebGLId program) {
- ASSERT_TRUE(hasProgram(program));
- program_set_.erase(program);
- }
-
- virtual void useProgram(WebGLId program) {
- if (!program)
- return;
- ASSERT_TRUE(hasProgram(program));
- }
-
- virtual WebKit::WebGLId createShader(WebKit::WGC3Denum) {
- unsigned shader = next_shader_id_number_;
- shader_set_.insert(shader);
- next_shader_id_number_++;
- return shader;
- }
-
- virtual void deleteShader(WebKit::WebGLId shader) {
- ASSERT_TRUE(hasShader(shader));
- shader_set_.erase(shader);
- }
-
- virtual void attachShader(WebGLId program, WebGLId shader) {
- ASSERT_TRUE(hasProgram(program));
- ASSERT_TRUE(hasShader(shader));
- }
-
- protected:
- unsigned next_program_id_number_;
- unsigned next_shader_id_number_;
- std::set<unsigned> program_set_;
- std::set<unsigned> shader_set_;
-};
-
class GLRendererShaderTest : public testing::Test {
protected:
GLRendererShaderTest() {
- output_surface_ = FakeOutputSurface::Create3d(
- scoped_ptr<TestWebGraphicsContext3D>(
- new ShaderCreatorMockGraphicsContext())).Pass();
+ output_surface_ = FakeOutputSurface::Create3d().Pass();
CHECK(output_surface_->BindToClient(&output_surface_client_));
resource_provider_ =

Powered by Google App Engine
This is Rietveld 408576698