Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 46163003: Consolidate test contexts and remove unused ones (Closed)

Created:
7 years, 1 month ago by jamesr
Modified:
7 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Consolidate test contexts and remove unused ones This folds several simple TestWebGraphicsContext3D subclasses into the base class and removes several unused TestWebGraphicsContext3D subclasses. The goal is to remove dead code and make it easier to convert over to a GLES2Interface-based test base. R=danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232876

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -284 lines) Patch
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 1 chunk +1 line, -61 lines 0 comments Download
D cc/test/fake_web_graphics_context_3d_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 2 4 chunks +29 lines, -1 line 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 1 2 8 chunks +37 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 9 chunks +41 lines, -172 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
7 years, 1 month ago (2013-10-31 18:13:41 UTC) #1
danakj
LGTM https://codereview.chromium.org/46163003/diff/1/cc/test/test_web_graphics_context_3d.cc File cc/test/test_web_graphics_context_3d.cc (right): https://codereview.chromium.org/46163003/diff/1/cc/test/test_web_graphics_context_3d.cc#newcode470 cc/test/test_web_graphics_context_3d.cc:470: void TestWebGraphicsContext3D::enable(GLenum cap) {} why override these and ...
7 years, 1 month ago (2013-10-31 18:20:02 UTC) #2
jamesr
On 2013/10/31 18:20:02, danakj wrote: > LGTM > > https://codereview.chromium.org/46163003/diff/1/cc/test/test_web_graphics_context_3d.cc > File cc/test/test_web_graphics_context_3d.cc (right): > ...
7 years, 1 month ago (2013-10-31 18:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/46163003/80001
7 years, 1 month ago (2013-10-31 18:32:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/46163003/80001
7 years, 1 month ago (2013-10-31 23:23:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217033
7 years, 1 month ago (2013-11-01 03:09:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/46163003/360001
7 years, 1 month ago (2013-11-04 20:53:46 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 01:34:43 UTC) #8
Message was sent while issue was closed.
Change committed as 232876

Powered by Google App Engine
This is Rietveld 408576698