Issue 461603002: Replace Strings with Names in load and store ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461603002: Replace Strings with Names in load and store ICs. (Closed)

Created:
6 years, 4 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Replace Strings with Names in load and store ICs. Mostly mechanical, the only interesting change is in KeyedLoadIC::Load, where we now handle x[symbol] in the same way we handle x['string'] R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23038

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -40 lines)			Patch
M	src/accessors.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/accessors.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ic.h	View	1	7 chunks	+15 lines, -15 lines	0 comments	Download
M	src/ic.cc	View	1 2	15 chunks	+19 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

6 years, 4 months ago (2014-08-11 12:57:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as 23038 (presubmit successful).