Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 461593002: Remove V8TryCatchRethrowScope from private script bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 625c2e13cc2e446fb7c7b110c245ec19c4fa569c..9aa74a8ce90f8eb0f665851643932da20ece15f3 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -561,7 +561,6 @@ bool {{v8_class}}::PrivateScript::{{method.name}}Method({{method.argument_declar
{% endif %}
ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{cpp_class}}", scriptState->context()->Global(), scriptState->isolate());
v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
{% if method.idl_type == 'void' %}
PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
if (block.HasCaught()) {
@@ -569,6 +568,7 @@ bool {{v8_class}}::PrivateScript::{{method.name}}Method({{method.argument_declar
// FIXME: We should support more exceptions.
RELEASE_ASSERT_NOT_REACHED();
}
+ block.ReThrow();
return false;
}
{% else %}
@@ -578,6 +578,7 @@ bool {{v8_class}}::PrivateScript::{{method.name}}Method({{method.argument_declar
// FIXME: We should support more exceptions.
RELEASE_ASSERT_NOT_REACHED();
}
+ block.ReThrow();
return false;
}
{{method.private_script_v8_value_to_local_cpp_value}};
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698