Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 461563002: Avoid preloader-induced test flakiness. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid preloader-induced test flakiness. If a preload request for <img> preload fails, the request will be retried on parsing the element as per normal. This might result in more than one request for the same resource, and consequently more than one console error message might be output. For img-crossorigin-no-credentials-prompt.html, avoid having the preloader kick in by not relying on an external script. R= BUG=239918 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179918

Patch Set 1 #

Patch Set 2 : Remove now-redundant window.jsTestIsAsync assignment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M LayoutTests/http/tests/security/img-crossorigin-no-credentials-prompt.html View 1 1 chunk +18 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. Some flakiness seen since adding last week, http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fimg-crossorigin-no-credentials-prompt.html
6 years, 4 months ago (2014-08-11 06:45:44 UTC) #1
Mike West
lgtm I guess this was just a race between test-runner spitting out its text, and ...
6 years, 4 months ago (2014-08-11 07:09:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/461563002/20001
6 years, 4 months ago (2014-08-11 07:10:26 UTC) #3
sof
On 2014/08/11 07:09:41, Mike West wrote: > lgtm > > I guess this was just ...
6 years, 4 months ago (2014-08-11 07:42:38 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:05:19 UTC) #5
Message was sent while issue was closed.
Change committed as 179918

Powered by Google App Engine
This is Rietveld 408576698