Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461543002: [FileAPI] Check Platform availablity before using it in DOMFileSystem (Closed)

Created:
6 years, 4 months ago by tzik
Modified:
6 years, 4 months ago
Reviewers:
nhiroki
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Project:
blink
Visibility:
Public.

Description

[FileAPI] Check Platform availablity before using it in DOMFileSystem BUG=399803 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179909

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : move fileSystem() check above #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M Source/modules/filesystem/DOMFileSystem.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.cpp View 1 2 10 chunks +52 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
6 years, 4 months ago (2014-08-11 04:29:44 UTC) #1
nhiroki
lgtm https://codereview.chromium.org/461543002/diff/20001/Source/modules/filesystem/DOMFileSystemBase.cpp File Source/modules/filesystem/DOMFileSystemBase.cpp (right): https://codereview.chromium.org/461543002/diff/20001/Source/modules/filesystem/DOMFileSystemBase.cpp#newcode78 Source/modules/filesystem/DOMFileSystemBase.cpp:78: return 0; "return nullptr;"? https://codereview.chromium.org/461543002/diff/20001/Source/modules/filesystem/DOMFileSystemBase.cpp#newcode198 Source/modules/filesystem/DOMFileSystemBase.cpp:198: } How ...
6 years, 4 months ago (2014-08-11 04:56:38 UTC) #2
tzik
https://codereview.chromium.org/461543002/diff/20001/Source/modules/filesystem/DOMFileSystemBase.cpp File Source/modules/filesystem/DOMFileSystemBase.cpp (right): https://codereview.chromium.org/461543002/diff/20001/Source/modules/filesystem/DOMFileSystemBase.cpp#newcode78 Source/modules/filesystem/DOMFileSystemBase.cpp:78: return 0; On 2014/08/11 04:56:38, nhiroki wrote: > "return ...
6 years, 4 months ago (2014-08-11 05:12:08 UTC) #3
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-11 05:12:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/461543002/40001
6 years, 4 months ago (2014-08-11 05:13:05 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 06:11:12 UTC) #6
Message was sent while issue was closed. 
Change committed as 179909

Powered by Google App Engine
This is Rietveld 408576698