Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 461523002: Remove unused UMAs about V8DOMWindowShell (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove unused UMAs about V8DOMWindowShell This CL removes V8DOMWindowShell.createContext.IsolatedWorld and V8DOMWindowShell.createContext.MainWorld. They are already dead. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288984

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-11 01:04:10 UTC) #1
Alexei Svitkine (slow)
Were these ever logged? If so, it's better to mark them with an <obsolete> tag. ...
6 years, 4 months ago (2014-08-11 14:54:44 UTC) #2
haraken
On 2014/08/11 14:54:44, Alexei Svitkine wrote: > Were these ever logged? If so, it's better ...
6 years, 4 months ago (2014-08-11 15:19:39 UTC) #3
Alexei Svitkine (slow)
Please mark them as "obsolete" instead (with the <obsolete> tag), so that old data viewed ...
6 years, 4 months ago (2014-08-11 17:03:32 UTC) #4
haraken
On 2014/08/11 17:03:32, Alexei Svitkine wrote: > Please mark them as "obsolete" instead (with the ...
6 years, 4 months ago (2014-08-12 01:16:22 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-12 05:03:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/461523002/20001
6 years, 4 months ago (2014-08-12 05:05:27 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:37:25 UTC) #8
Message was sent while issue was closed.
Change committed as 288984

Powered by Google App Engine
This is Rietveld 408576698