Split Screen mode implementation.

Split Screen mode implementation.

Implements Split Screen mode and window cycling behavior.
Resubmit of https://codereview.chromium.org/420603011/

TBR=oshima@chromium.org,mukai@chromium.org

BUG=383421
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289064

[mfomitchev, 2014-08-10 23:34:08]

Re-submit of the split screen implementation with the Asan test fix

[Jun Mukai, 2014-08-11 17:56:28]

Are you waiting reviews from us or submitting TBR notice?
If former, could you explain where is the difference from the previous one?

[Jun Mukai, 2014-08-11 18:00:42]

On 2014/08/11 17:56:28, Jun Mukai wrote:
> Are you waiting reviews from us or submitting TBR notice?
> If former, could you explain where is the difference from the previous one?

note that if the fix is really tiny -- like the diff from patchset 1 and 2 in
this review -- I'd say you can just submit with TBR, you've got the approval
already.

[mfomitchev, 2014-08-11 18:07:26]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2014-08-11 18:07:27]

The CQ bit was unchecked by mfomitchev@chromium.org

[mfomitchev, 2014-08-11 18:08:01]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2014-08-11 18:09:06]

Yup, that's the only change. Thanks.

[mfomitchev, 2014-08-11 18:29:47]

The CQ bit was unchecked by mfomitchev@chromium.org

[mfomitchev, 2014-08-11 18:29:49]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2014-08-11 19:17:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/461503002/20001

[commit-bot: I haz the power, 2014-08-12 00:17:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 03:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 03:06:42]

Failed to apply patch for athena/wm/window_manager_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file athena/wm/window_manager_impl.cc
  Hunk #1 succeeded at 10 with fuzz 1 (offset 2 lines).
  Hunk #2 succeeded at 40 (offset 4 lines).
  Hunk #3 FAILED at 64.
  Hunk #4 succeeded at 112 with fuzz 1 (offset 11 lines).
  Hunk #5 succeeded at 153 (offset 14 lines).
  Hunk #6 succeeded at 198 (offset 14 lines).
  1 out of 6 hunks FAILED -- saving rejects to file
athena/wm/window_manager_impl.cc.rej

Patch:       athena/wm/window_manager_impl.cc
Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index
fb06188a4ec86ea6e7e679e84697993ae49326d1..89b1b9418cab2600c909dfc844d94bbd210ffa08
100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -8,6 +8,7 @@
 #include "athena/input/public/accelerator_manager.h"
 #include "athena/screen/public/screen_manager.h"
 #include "athena/wm/bezel_controller.h"
+#include "athena/wm/mru_window_tracker.h"
 #include "athena/wm/public/window_manager_observer.h"
 #include "athena/wm/split_view_controller.h"
 #include "athena/wm/window_overview_mode.h"
@@ -35,6 +36,8 @@ class WindowManagerImpl : public WindowManager,
   // WindowManager:
   virtual void ToggleOverview() OVERRIDE;
 
+  virtual bool IsOverviewModeActive() OVERRIDE;
+
  private:
   enum Command {
     COMMAND_TOGGLE_OVERVIEW,
@@ -61,12 +64,15 @@ class WindowManagerImpl : public WindowManager,
   virtual bool OnAcceleratorFired(int command_id,
                                   const ui::Accelerator& accelerator) OVERRIDE;
 
+  // Should be declared first so that it is destoyed last.
+  ObserverList<WindowManagerObserver> observers_;
+
   scoped_ptr<aura::Window> container_;
+  scoped_ptr<MruWindowTracker> mru_window_tracker_;
   scoped_ptr<WindowOverviewMode> overview_;
   scoped_ptr<BezelController> bezel_controller_;
   scoped_ptr<SplitViewController> split_view_controller_;
   scoped_ptr<wm::WMState> wm_state_;
-  ObserverList<WindowManagerObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowManagerImpl);
 };
@@ -98,8 +104,10 @@ WindowManagerImpl::WindowManagerImpl() {
   container_.reset(ScreenManager::Get()->CreateDefaultContainer(params));
   container_->SetLayoutManager(new AthenaContainerLayoutManager);
   container_->AddObserver(this);
+  mru_window_tracker_.reset(new MruWindowTracker(container_.get()));
   bezel_controller_.reset(new BezelController(container_.get()));
-  split_view_controller_.reset(new SplitViewController());
+  split_view_controller_.reset(new SplitViewController(
+      container_.get(), mru_window_tracker_.get(), this));
   bezel_controller_->set_left_right_delegate(split_view_controller_.get());
   container_->AddPreTargetHandler(bezel_controller_.get());
   wm_state_.reset(new wm::WMState());
@@ -134,15 +142,26 @@ void WindowManagerImpl::ToggleOverview() {
   SetInOverview(overview_.get() == NULL);
 }
 
+bool WindowManagerImpl::IsOverviewModeActive() {
+  return overview_;
+}
+
 void WindowManagerImpl::SetInOverview(bool active) {
   bool in_overview = !!overview_;
   if (active == in_overview)
     return;
 
   if (active) {
-    overview_ = WindowOverviewMode::Create(container_.get(), this);
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
                       OnOverviewModeEnter());
+    // Re-stack all windows in the order defined by mru_window_tracker_.
+    aura::Window::Windows window_list = mru_window_tracker_->GetWindowList();
+    aura::Window::Windows::iterator it;
+    for (it = window_list.begin(); it != window_list.end(); ++it)
+      container_->StackChildAtTop(*it);
+    overview_ = WindowOverviewMode::Create(container_.get(),
+                                           mru_window_tracker_.get(),
+                                           this);
   } else {
     overview_.reset();
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
@@ -168,8 +187,7 @@ void
WindowManagerImpl::RemoveObserver(WindowManagerObserver* observer) {
 }
 
 void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
-  CHECK_EQ(container_.get(), window->parent());
-  container_->StackChildAtTop(window);
+  mru_window_tracker_->MoveToFront(window);
   wm::ActivateWindow(window);
   SetInOverview(false);
 }

[mfomitchev, 2014-08-12 17:00:47]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2014-08-12 17:09:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/461503002/40001

[commit-bot: I haz the power, 2014-08-12 21:33:01]

Change committed as 289064

[sadrul, 2014-08-13 05:17:29]

https://codereview.chromium.org/461503002/diff/40001/athena/wm/window_manager...
File athena/wm/window_manager_impl.cc (left):

https://codereview.chromium.org/461503002/diff/40001/athena/wm/window_manager...
athena/wm/window_manager_impl.cc:80: ObserverList<WindowManagerObserver>
observers_;
The CL is still breaking the asan builders. This change in ordering of the
variables is not the right fix for it. You should just destroy the
mru_window_tracker_ explicitly in ~WindowManagerImpl before destroying
container_

[hashimoto, 2014-08-13 06:51:44]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/468053002/ by hashimoto@chromium.org.

The reason for reverting is: Breaking "Linux Chromium OS ASan LSan Tests (3)"
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20....

[mfomitchev, 2014-08-13 13:27:31]

https://codereview.chromium.org/461503002/diff/40001/athena/wm/window_manager...
File athena/wm/window_manager_impl.cc (left):

https://codereview.chromium.org/461503002/diff/40001/athena/wm/window_manager...
athena/wm/window_manager_impl.cc:80: ObserverList<WindowManagerObserver>
observers_;
Ok, I've done that. It seems a bit unfortunate that we need to manually delete
all these members rather than rely on scoped_ptr to do the job, but I guess it's
superior to manipulating the member ordering since it's explicit and obvious.
FWIW the first fix did fix the original break with was with the observers_ list.