Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 461463002: Remove unused gn tool script. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, noelallen1
Project:
chromium
Visibility:
Public.

Description

Remove unused gn tool script. No intended behavior change. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
D build/toolchain/android/find_android_compiler.py View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
There's another copy of this script in native_client/build/toolchain/android/find_android_compiler.py . In general, a lot of the ...
6 years, 4 months ago (2014-08-10 18:28:59 UTC) #1
brettw
As I mentioned in the other core review, nothing automatic happens. Come chat with me ...
6 years, 4 months ago (2014-08-11 16:35:19 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-08-11 16:35:25 UTC) #3
Nico
(cc'ing noel so he can merge this to nacl)
6 years, 4 months ago (2014-08-11 16:38:12 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-11 16:38:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/461463002/1
6 years, 4 months ago (2014-08-11 16:39:45 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 16:44:47 UTC) #7
Message was sent while issue was closed.
Change committed as 288728

Powered by Google App Engine
This is Rietveld 408576698