Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 461443002: Update Blink to include blink_test_environment.h (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
Avi (use Gerrit), blink-reviews
Project:
blink
Visibility:
Public.

Description

Update Blink to include blink_test_environment.h And call the new functions: SetUpBlinkTestEnvironment() and TearDownBlinkTestEnvironment(). BUG=None TEST=webkit_unit_tests R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/web/tests/RunAllTests.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Chromium side -> https://codereview.chromium.org/458013002/
6 years, 4 months ago (2014-08-10 13:57:25 UTC) #1
abarth-chromium
LGTM, but it's wrong for this code to include a header from content directly... It's ...
6 years, 4 months ago (2014-08-10 15:31:53 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-11 16:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/461443002/1
6 years, 4 months ago (2014-08-11 16:50:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 17:50:27 UTC) #5
Message was sent while issue was closed.
Change committed as 179977

Powered by Google App Engine
This is Rietveld 408576698