Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 46143003: NewWebSocketChannel sends a message endlessly (Closed)

Created:
7 years, 1 month ago by yhirano
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

NewWebSocketChannel sends a message endlessly Mis-setting "final" variable in NewWebSocketChannel::sendInternal leads to infinite loop. BUG=275459 R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161044

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
7 years, 1 month ago (2013-10-31 08:10:50 UTC) #1
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/46143003/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.cpp File Source/modules/websockets/NewWebSocketChannelImpl.cpp (right): https://codereview.chromium.org/46143003/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.cpp#newcode319 Source/modules/websockets/NewWebSocketChannelImpl.cpp:319: final = (m_sentSizeOfTopMessage + size == message.text.length()); message.arrayBuffer->byteLength() ?
7 years, 1 month ago (2013-10-31 09:04:32 UTC) #2
yhirano
https://codereview.chromium.org/46143003/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.cpp File Source/modules/websockets/NewWebSocketChannelImpl.cpp (right): https://codereview.chromium.org/46143003/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.cpp#newcode319 Source/modules/websockets/NewWebSocketChannelImpl.cpp:319: final = (m_sentSizeOfTopMessage + size == message.text.length()); On 2013/10/31 ...
7 years, 1 month ago (2013-10-31 09:16:12 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
7 years, 1 month ago (2013-10-31 09:19:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/46143003/70001
7 years, 1 month ago (2013-10-31 09:20:34 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 10:14:48 UTC) #6
Message was sent while issue was closed. 
Change committed as 161044

Powered by Google App Engine
This is Rietveld 408576698