Issue 461423002: Revert of Create NaCl build of gtest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461423002: Revert of Create NaCl build of gtest. (Closed)

Created:
6 years, 4 months ago by Joao da Silva

Modified:
6 years, 4 months ago

Reviewers:
bradnelson, bradn, Nick Bray (chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Create NaCl build of gtest. (patchset #4 of https://codereview.chromium.org/401453002/) Reason for revert: Broke the tree: gyp: Key 'defines' repeated at level 6 with key path 'conditions.0.1.targets.0' while reading /Volumes/data/b/build/slave/Mac/build/src/testing/gtest_nacl.gyp Original issue's description: > Create NaCl build of gtest. > > BUG=401761 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289216

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -142 lines)			Patch
M	build/all.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	testing/gtest.gyp	View	1 chunk	+34 lines, -4 lines	0 comments	Download
D	testing/gtest.gypi	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	testing/gtest_nacl.gyp	View	1 chunk	+0 lines, -92 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/461423002/1

6 years, 4 months ago (2014-08-13 09:03:05 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 4 months ago (2014-08-13 09:03:05 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-13 09:03:06 UTC) #4

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages