add a test app using notification provider API

add a test app using notification provider API

Add a test app using notification provider API. When a notification is
created, updated or cleared, the app will display the newly created
notification, updates, and closes it.

BUG=397197
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289756

[liyanhou, 2014-08-13 23:34:40]

Could you take a look? Thank you!

[Pete Williamson, 2014-08-14 00:07:55]

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/notification_provider/test_app/main.js
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/main.js:112:
if (details.tyep = "list" && "items" in details) {
tyep -> type?

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/main.js:132:
// TODO: add button image after image is implemented
If you actually check in a TODO (instead of doing it beforehand), put your name
by it (that doesn't mean that you have to do it, that means that you are the one
who made the coment)

ex:
  // TODO(liyanhou): Add button image after image is implemented.

Also, please check the whole file to make sure comments begin with a capital
letter and end with a period, and that you use complete sentences (it is our
coding style guideline for chromium).

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/notification_provider/test_app/manifest.json
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/manifest.json:5:
"version" : "0.3.1",
Just curious - why 0.3.1?

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/notification_provider/test_app/window.html
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/window.html:11:
<h1>Notification Provider API Testt</h1>
Nit: Testt -> Test

[liyanhou, 2014-08-14 00:41:51]

Addressed comments. Could you take another look?

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/notification_provider/test_app/main.js
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/main.js:112:
if (details.tyep = "list" && "items" in details) {
On 2014/08/14 00:07:55, Pete Williamson wrote:
> tyep -> type?

Done.

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/main.js:132:
// TODO: add button image after image is implemented
On 2014/08/14 00:07:55, Pete Williamson wrote:
> If you actually check in a TODO (instead of doing it beforehand), put your
name
> by it (that doesn't mean that you have to do it, that means that you are the
one
> who made the coment)
> 
> ex:
>   // TODO(liyanhou): Add button image after image is implemented.
> 
> Also, please check the whole file to make sure comments begin with a capital
> letter and end with a period, and that you use complete sentences (it is our
> coding style guideline for chromium).

Done.

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/notification_provider/test_app/manifest.json
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/manifest.json:5:
"version" : "0.3.1",
On 2014/08/14 00:07:55, Pete Williamson wrote:
> Just curious - why 0.3.1?

Sorry I copied it from somewhere else when I first started the file and didn't
know the syntax and format. Changed it to a version number that makes more
sense.

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/notification_provider/test_app/window.html
(right):

https://codereview.chromium.org/461403005/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/notification_provider/test_app/window.html:11:
<h1>Notification Provider API Testt</h1>
On 2014/08/14 00:07:55, Pete Williamson wrote:
> Nit: Testt -> Test

Done.

[Pete Williamson, 2014-08-14 00:43:30]

lgtm

[liyanhou, 2014-08-14 00:49:57]

The CQ bit was checked by liyanhou@chromium.org

[commit-bot: I haz the power, 2014-08-14 00:55:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/liyanhou@chromium.org/461403005/40001

[commit-bot: I haz the power, 2014-08-14 13:04:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-14 13:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 13:10:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[liyanhou, 2014-08-14 20:14:59]

The CQ bit was checked by liyanhou@chromium.org

[commit-bot: I haz the power, 2014-08-14 20:17:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/liyanhou@chromium.org/461403005/60001

[commit-bot: I haz the power, 2014-08-15 03:06:48]

Committed patchset #3 (60001) as 289756