Issue 461403003: Add VID/PID pairs for known U2F devices. Interrim explicit listing until HID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461403003: Add VID/PID pairs for known U2F devices. Interrim explicit listing until HID (Closed)

Created:
6 years, 4 months ago by Arnar Birgisson

Modified:
6 years, 4 months ago

Reviewers:
xiyuan, mschilder1, Marius

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add VID/PID pairs for known U2F devices. Interrim explicit listing until HID APIs support the U2F spec complient discovery based on Usage Pages. Request batch attestation certs for consumer appIds BUG=403301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289452

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	chrome/browser/resources/cryptotoken/gnubby-u2f.js	View		2 chunks	+9 lines, -3 lines	0 comments	Download
	M	chrome/browser/resources/cryptotoken/manifest.json	View		2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/461403003/1

6 years, 4 months ago (2014-08-13 16:36:45 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-13 22:40:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 289452

Expand Messages | Collapse Messages