Issue 461363003: add const to arrays of member functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461363003: add const to arrays of member functions (Closed)

Created:
6 years, 4 months ago by caryclark

Modified:
6 years, 4 months ago

Reviewers:
reed, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

add const to arrays of member functions running 'size ./out/Release/libskia_core.a' revealed a couple of places where path ops chose poorly and declared arrays of member functions to be unnecessarily writable. TBR=reed Committed: https://skia.googlesource.com/skia/+/2e40381060794745562c4a26896970406114b07a

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	src/pathops/SkIntersections.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkIntersections.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkPathOpsBounds.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkPathOpsBounds.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/461363003/1

6 years, 4 months ago (2014-08-25 13:46:42 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-25 13:53:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 2e40381060794745562c4a26896970406114b07a

Expand Messages | Collapse Messages