Fix Has dispatch ServiceWorker CacheStorage API.

Fix Has dispatch ServiceWorker CacheStorage API.

While we're here, remove silly DCHECKs on pointers that are
dereferenced in the next line anyway.

R=asanka@chromium.org,jsbell@chromium.org
TBR=falken@chromium.org,dominicc@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291247

[gavinp, 2014-08-21 17:04:37]

PTAL everyone.

These DCHECKs were silly, so let's toss them.

The most important thing though is in the dispatch of Has. Whoops!

[gavinp, 2014-08-21 17:05:52]

N.B. these changes are included in https://codereview.chromium.org/474593002/ ,
but review inertia is high enough now that I'm carving out highly desirable
changes to land separately.

[jsbell, 2014-08-21 17:45:54]

lgtm

[gavinp, 2014-08-21 17:52:56]

Thanks jsbell!

After talking this over with jsbell, I've decided to land this TBR from owners
on Chromium side, since it's pretty clearly desirable.

[gavinp, 2014-08-21 17:53:00]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-21 17:56:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/461343006/1

[commit-bot: I haz the power, 2014-08-21 23:46:29]

Committed patchset #1 (1) as 291247

[falken, 2014-08-22 06:23:42]

lgtm to fix has()

For future reference, is:
DCHECK(p);
p->Foo();

an anti-pattern? It occurs sometimes in our code.

[jsbell, 2014-08-22 18:40:31]

https://codereview.chromium.org/461343006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
(right):

https://codereview.chromium.org/461343006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc:170:
script_context_->Send(new ServiceWorkerHostMsg_CacheStorageDelete(
Oops, this needed to be updated too - sends the wrong message.

[gavinp, 2014-08-27 19:43:48]

https://codereview.chromium.org/461343006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
(right):

https://codereview.chromium.org/461343006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc:170:
script_context_->Send(new ServiceWorkerHostMsg_CacheStorageDelete(
On 2014/08/22 18:40:31, jsbell wrote:
> Oops, this needed to be updated too - sends the wrong message.

In fairness, the return value for Delete conforms with the spec requirements for
Has, so provided the user does not make any subsequent calls this mistake should
be undetectable.

I'll upload a CL to follow this up now.

[jsbell, 2014-08-27 20:10:00]

On 2014/08/27 19:43:48, gavinp wrote:
> 
> I'll upload a CL to follow this up now.

I fixed already in r291529