Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 461333002: Nullify video context provider when there is no harware compositor. (Closed)

Created:
6 years, 4 months ago by hush (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Yaron, boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Nullify video context provider when there is no harware compositor. BUG=403882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289474

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hush (inactive)
Setting video context provider to NULL after the last compositor releases hardware. This will set ...
6 years, 4 months ago (2014-08-13 06:48:24 UTC) #1
boliu
still racy, but I'm willing to land this small fix for m37 lgtm +yaron for ...
6 years, 4 months ago (2014-08-13 15:15:52 UTC) #2
hush (inactive)
On 2014/08/13 15:15:52, boliu wrote: > still racy, but I'm willing to land this small ...
6 years, 4 months ago (2014-08-13 16:44:18 UTC) #3
boliu
On 2014/08/13 16:44:18, hush wrote: > On 2014/08/13 15:15:52, boliu wrote: > > still racy, ...
6 years, 4 months ago (2014-08-13 16:47:08 UTC) #4
Yaron
lgtm
6 years, 4 months ago (2014-08-13 16:47:45 UTC) #5
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-13 17:09:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/461333002/20001
6 years, 4 months ago (2014-08-13 17:11:09 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 21:31:24 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 06:23:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (20001) as 289474

Powered by Google App Engine
This is Rietveld 408576698