Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 461323006: input[type=date] warns if specified string is invalid. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

input[type=date] warns if specified string is invalid. We show a console message if: - An invalid string is set to 'value' IDL attribute. - An invalid string is set to 'value' content attribute. - 'date' is set to 'type' attribute and existing 'value' content attribute is invalid. - 'date' is set to 'type' attribute and existing user-specified value is invalid. BUG=397952 TEST=Update expectations of automated tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180341

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/ValidityState-typeMismatch-date-expected.txt View 1 chunk +34 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/date-pseudo-classes-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/date-setrangetext-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/input-date-validation-message-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-collection-radio-node-list-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/spatial-navigation/snav-date-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Keishi, would you review this please?
6 years, 4 months ago (2014-08-15 07:49:28 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-15 08:15:49 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-15 08:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/461323006/20001
6 years, 4 months ago (2014-08-15 08:25:19 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 08:47:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (20001) as 180341

Powered by Google App Engine
This is Rietveld 408576698