Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 461313002: Update presubmit files to send windows tryjobs to swarming bots, now that the CQ has switched over. (Closed)

Created:
6 years, 4 months ago by jam
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, tdresser+watch_chromium.org, haitaol+watch_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update presubmit files to send windows tryjobs to swarming bots, now that the CQ has switched over. R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M PRESUBMIT.py View 3 chunks +6 lines, -3 lines 0 comments Download
M base/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M jingle/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M net/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 4 months ago (2014-08-13 01:51:27 UTC) #1
Avi (use Gerrit)
I'm not an expert here. This looks entirely plausible (so LGTM for what it's worth) ...
6 years, 4 months ago (2014-08-13 02:00:01 UTC) #2
jam
On 2014/08/13 02:00:01, Avi wrote: > I'm not an expert here. This looks entirely plausible ...
6 years, 4 months ago (2014-08-13 02:01:08 UTC) #3
jam
6 years, 4 months ago (2014-08-13 02:01:59 UTC) #4
On 2014/08/13 02:01:08, jam wrote:
> On 2014/08/13 02:00:01, Avi wrote:
> > I'm not an expert here. This looks entirely plausible (so LGTM for what it's
> > worth) but you might want to get it double-checked by someone else.
> 
> ah, well if it makes you more comfortable, this matches an earlier cl that I
> landed which does the same for mac :)
> 
> I'll land this and verify using "git cl try" that it works.

actually, without even committing it, I did a "git cl try" from that checkout
and it did the right thing.

Powered by Google App Engine
This is Rietveld 408576698