Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5148)

Unified Diff: apps/app_shim/extension_app_shim_handler_mac.h

Issue 461303002: [Mac] Bounce app shims when app windows request attention. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update FakeHost in test. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_shim/chrome_main_app_mode_mac.mm ('k') | apps/app_shim/extension_app_shim_handler_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_shim/extension_app_shim_handler_mac.h
diff --git a/apps/app_shim/extension_app_shim_handler_mac.h b/apps/app_shim/extension_app_shim_handler_mac.h
index 0f7ae0c37195f83ca777747bbb42acf5fddfb302..bc8efb14c077c65e57f59f83468fd2b44de807b7 100644
--- a/apps/app_shim/extension_app_shim_handler_mac.h
+++ b/apps/app_shim/extension_app_shim_handler_mac.h
@@ -80,8 +80,14 @@ class ExtensionAppShimHandler : public AppShimHandler,
static void FocusAppForWindow(AppWindow* app_window);
// Brings the window to the front without showing it and instructs the shim to
- // request user attention. Returns false if there is no shim for this window.
- static bool RequestUserAttentionForWindow(AppWindow* app_window);
+ // request user attention. If there is no shim, show the app and return false.
+ static bool ActivateAndRequestUserAttentionForWindow(AppWindow* app_window);
+
+ // Instructs the shim to request user attention. Returns false if there is no
+ // shim for this window.
+ static void RequestUserAttentionForWindow(
+ AppWindow* app_window,
+ AppShimAttentionType attention_type);
// Called by AppControllerMac when Chrome hides.
static void OnChromeWillHide();
« no previous file with comments | « apps/app_shim/chrome_main_app_mode_mac.mm ('k') | apps/app_shim/extension_app_shim_handler_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698